Re: [PATCH v4] crc32c: Implement CRC32c with slicing-by-8 algorithm

From: Herbert Xu
Date: Tue Oct 04 2011 - 03:00:30 EST

On Mon, Oct 03, 2011 at 05:55:10PM -0700, Darrick J. Wong wrote:
> So what I think I'm hearing is...
> 1. Apply Bob's slice-by-8 algorithm patch to regular crc32.
> 2. Adapt crc32's build code to generate crc32c as well.
> 3. Remove crypto/crc32c.c's implementation and have it wrap the code generated
> by #2.
> 4. Retain the current libcrc32c. I guess if you don't configure CRYPTO and
> CRYPTO_CRC32C then it could also just reference the generated crc32c functions
> directly.
> Is this a satisfactory way to move forward?

All good except that you don't really have to touch libcrc32c
at all.

Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page:
PGP Key:
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at