Re: [RFCv3][PATCH 1/4] replace string_get_size() arrays

From: Dave Hansen
Date: Tue Oct 04 2011 - 16:52:22 EST

On Tue, 2011-10-04 at 13:42 -0700, Joe Perches wrote:
> > Right, but we're only handling u64.
> So the declaration should be:
> static const char byte_units[] = " KMGTPE";

I guess that's worth a comment. But that first character doesn't get
used. There were two alternatives:

static const char byte_units[] = "_KMGTPE";

or something along the lines of:

+ static const char byte_units[] = "KMGTPE";
+ index--;
+ /* index=-1 is plain 'B' with no other unit */
+ if (index >= 0) {

We don't ever _actually_ look at the space (or underscore). I figured
the _ was nicer since it would be _obvious_ if it ever got printed out

-- Dave

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at