Re: [Quilt-dev] [RFC][PATCH v2][QUILT] Add gpg signing to quilt mail

[Andreas Gruenbacher]

On Tue, 2011-10-04 at 14:37 -0400, Steven Rostedt wrote:
> On Tue, 2011-10-04 at 11:26 -0700, Greg KH wrote:
> 
> > > What are git's "split" subject: lines?
> > 
> > Do the following:
> >  $ git show --pretty=email 21d17dd2a377ba894f26989915eb3c6e427a3656
> > 
> > and look at how the Subject line is formatted:
> > 	Subject: [PATCH] ASoC: Fix setting update bits for WM8753_LADC and
> > 	 WM8753_RADC
> > 
> > Which is legal for email subject lines.  But quilt can't handle this and
> > ends up thinking the data after the Subject: line is part of the patch
> > text body and messes stuff up when doing 'quilt mail' later.

Aah, all this email parsing code is so ugly.  I think it works now
though.

> > Oh, then there's the issue of quilt not handling ',' in a Signed-off-by
> > line as a valid email address name, but I've been living with that one
> > for years...

That's not even valid in email addresses.  The proper way would be to
double-quote the "display name" which probably contains the comma, but
then quilt's edmail script still won't understand it.  Is this a real
problem?

Andreas

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/