Re: [PATCH 00/11] IO-less dirty throttling v12
From: Andi Kleen
Date: Wed Oct 05 2011 - 11:16:44 EST
Vivek Goyal <vgoyal@xxxxxxxxxx> writes:
> Will it make sense to break down this work in two patch series. First
> push IO less balance dirty pages and then all the complicated pieces
> of ratelimits.
I would be wary against too much refactoring of well tested patchkits.
I've seen too many cases where this can add nasty and subtle bugs,
given that our unit test coverage is usually relatively poor.
For example the infamous "absolute path names became twice as slow"
bug was very likely introduced in such a refactoring of a large VFS
While it's generally good to make things easier for reviewers too much
of a good thing can be quite bad.
ak@xxxxxxxxxxxxxxx -- Speaking for myself only
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/