Re: [PATCH 4/8] kernel/workqueue.c: unbound work queue rescuerruns on first cpu in cpumask_online_cpu
From: Tejun Heo
Date: Wed Oct 05 2011 - 16:01:05 EST
On Wed, Oct 05, 2011 at 09:19:22PM +0200, Peter Zijlstra wrote:
> On Wed, 2011-10-05 at 20:52 +0200, Thomas Gleixner wrote:
> > On Wed, 5 Oct 2011, Fenghua Yu wrote:
> > > From: Fenghua Yu <fenghua.yu@xxxxxxxxx>
> > >
> > > If work queue is unbound to a specific cpu, run rescuer on first cpu in
> > > cpumask_online_cpu instead BSP which could be offlined.
> > This patch needs to be applied separate from that series as it fixes a
> > bug which affects all architectures which can offline the boot cpu.
> AFAIKT it really doesn't matter in this case, all the rescuer_thread()
> needs is some bit set in that mask, since its UNBOUND it won't actually
> try and migrate to any cpu and just run wherever it woke up.
Yeah, for unbound, it's just a random fixed ID. Changing it
dynamically wouldn't break anything but is pointless. So, NACK.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/