Re: [PATCH] hwmon class driver registration with a device number
From: Guenter Roeck
Date: Thu Oct 06 2011 - 01:24:52 EST
On Thu, Oct 06, 2011 at 12:06:59AM -0400, Himanshu Chauhan wrote:
> > I can not comment on the merits of your patch. Unless I am missing
> > something, which may well be since I only spent a couple of minutes on
> > it, other device classes don't seem to provide a similar API, so I don't
> > know if or why it would make sense for hwmon. Maybe a driver which wants
> > to register a character device interface should do so independently of
> > hwmon.
> The idea here is to sit in the same class directory as of hwmon. Devices
> registered with this interface will have "dev" under, for example,
> /sys/class/hwmon/hwmon0/dev. To do the same inside the driver will be
> a bit more involved than a call.
> In my opinion other classes should also have similar interfaces.
I think you'll have to spend some more time and effort explaining the "what for".
Apparently no other device class needs this functionality so far, yet you
suggest that such an interface should exist for all device classes.
But you do so without explanation, or in other words without use case.
I for my part have no idea what you would use or need this new interface for,
and if there would be other less intrusive means to accomplish the same goal.
And I would want to see really good reasons to make a change like this.
Specifically looking at the hwmon subsystem, you are expected to use the lm-sensors
library to access all hwmon attributes. So I would expect your explanation to include
exactly what you want to accomplish and why, details why you believe that you can not
use the lm-sensors library, why you believe that the current infrastructure
does not provide the means you need to accomplish your goals, and why you
think that the existing infrastructure can not be modified to let you accomplish
what you want to do without such a - from a conceptual perspective - substantial change.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/