Re: [PATCH] pch_dma: Fix suspend issue

From: Tomoya MORINAGA
Date: Fri Oct 07 2011 - 06:33:31 EST

(2011/10/07 15:14), Vinod Koul wrote:
This is all is due to not saving nr_channels in probe and using that

Looking deeper, struct pch_dma defines array of length MAX_CHAN_NR for
channels. Then why do you allocate memory in probe as
pd = kzalloc(sizeof(struct pch_dma)+
sizeof(struct pch_dma_chan) * nr_channels, GFP_KERNEL);
what is the point in allocating additional memory for each channel?

Given this, why should there be predefined channel array in pcm_dma?

It would be great if we could fix this by dynamically allocating memory
for channels based on nr_channels and not wasting due to a static array.

You are right.
Current pch_dma driver looks like wasting memory.

We must review pch_dma driver again.

ROHM Co., Ltd.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at