Re: [PATCH v5 3.1.0-rc4-tip 26/26] uprobes: queue signals whilethread is singlestepping.
From: Oleg Nesterov
Date: Fri Oct 07 2011 - 13:03:12 EST
On 10/06, Srikar Dronamraju wrote:
> The patch (that I sent out as part of v5 patchset) uses per task
> pending sigqueue and start queueing the signals when the task
> singlesteps. After completion of singlestep, walks thro the pending
Yes, I see. Doesn't look very nice ;)
> But I was thinking if I should block signals instead of queueing them in
> a different sigqueue. So Idea is to block signals just before the task
> enables singlestep and unblock after task disables singlestep.
Agreed, this looks much, much better. In both cases the task is current,
it is safe to change ->blocked.
But please avoid sigprocmask(), we have set_current_blocked().
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/