Re: [PATCH 05/26] dynamic_debug: pr_err() call should not dependupon verbosity

[Joe Perches]

On Fri, 2011-10-07 at 14:33 -0600, jim.cromie@xxxxxxxxx wrote:
> Also convert to pr_err(), which supplies __func__ via pr_fmt.

Just a note on the changelog.
The original code already uses pr_err.

> diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c
[]
> @@ -334,8 +334,7 @@ static int ddebug_parse_query(char *words[], int nwords,
>  				query->last_lineno = query->first_lineno;
>  			}
>  		} else {
> -			if (verbose)
> -				pr_err("unknown keyword \"%s\"\n", words[i]);
> +			pr_err("unknown keyword \"%s\"\n", words[i]);


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/