Re: [PATCH 17/26] ARM: pxa: pxa95x is incompatible with earlier pxa

From: Arnd Bergmann
Date: Sun Oct 09 2011 - 07:32:21 EST


On Sunday 09 October 2011 14:36:52 Eric Miao wrote:
>
> They are actually not mutually exclusive - it's a trick we use to select
> MACH_TAVOREVB3 by default but this option also disappears once SAARB
> is selected.

Right. It's a bit hard to read when there are only two of them, but that
is the idea.

> The 'depends on ARCH_PXA_V7' could actually be removed here, as the
> option is already encapsulated in if ARCH_PXA_V7 ... endif. And this
> trick won't work very well when there are more than 2 boards.

Actually, the option is outside of the if ARCH_PXA_V7, but that could
easily be changed.

The trick works with as many boards as you like, it just gets a
little clumsy after while, as in

config MACH_OMAP_AUTO_BOARD
def_bool y
depends on !MACH_OMAP2_TUSB6010
depends on !MACH_OMAP_H4
depends on !MACH_OMAP_APOLLON
depends on !MACH_OMAP_APOLLON
depends on !MACH_OMAP_2430SDP
depends on !MACH_OMAP3_BEAGLE
depends on !MACH_DEVKIT8000
depends on !MACH_OMAP_LDP
depends on !MACH_OMAP3530_LV_SOM
depends on !MACH_OMAP3_TORPEDO
depends on !MACH_OVERO
depends on !MACH_OMAP3EVM
depends on !MACH_OMAP3517EVM
depends on !MACH_CRANEBOARD
depends on !MACH_OMAP3_PANDORA
depends on !MACH_OMAP3_TOUCHBOOK
depends on !MACH_NOKIA_N8X0
depends on !MACH_NOKIA_RM680
depends on !MACH_NOKIA_RX51
depends on !MACH_OMAP_ZOOM2
depends on !MACH_OMAP_ZOOM3
depends on !MACH_CM_T35
depends on !MACH_CM_T3517
depends on !MACH_IGEP0020
depends on !MACH_IGEP0030
depends on !MACH_SBC3530
depends on !MACH_OMAP_3630SDP
depends on !MACH_TI8168EVM
depends on !MACH_OMAP4_PANDA
select MACH_OMAP_GENERIC if ARCH_OMAP2
select MACH_OMAP_3430SDP if ARCH_OMAP3 && !ARCH_OMAP2
select MACH_OMAP_4430SDP if ARCH_OMAP4 && !ARCH_OMAP3 && !ARCH_OMAP2
help
The kernel needs to have support for at least one board
in order to build. If none is selected, default to the
generic board.

We should probably do something like this for the ARMv5 based PXA boards,
but at least a randconfig won't trigger that normally, just because there
are so many of them that almost always at least one is enabled. However,
an allnoconfig will fail with PXA right now.

Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/