Re: [patch v2 1/2] sched: Use resched IPI to kick off the nohz idlebalance

From: Vivek Goyal
Date: Mon Oct 10 2011 - 09:52:44 EST


On Fri, Oct 07, 2011 at 05:09:46PM -0700, Suresh Siddha wrote:
> On Thu, 2011-10-06 at 10:27 -0700, Vivek Goyal wrote:
> > On Mon, Oct 03, 2011 at 03:09:00PM -0700, Suresh Siddha wrote:
> > [..]
> > >
> > > [ This issue is present from 2.6.35+ kernels, but marking it -stable
> > > only from v3.0+ as the proposed fix depends on the scheduler_ipi()
> > > that is introduced recently. ]
> > >
> >
> > Hi Suresh,
> >
> > Are you planning to fix this issue for older kernels too? I am wondering
> > how to go about fixing it there.
> >
>
> Vivek, Initially when Prarit brought this issue to me, I gave an ugly
> quick fix (Appended) for a quick try. But I would recommend we back port
> the couple of mainline patches that introduced scheduler_ipi() code
> along with these two patches. Thoughts?

I agree that backporting scheduler_ipi() patches makes more sense.
Browsing through the code looks like we need just one commit which
introduced scheduler_ipi().

commit 184748cc50b2dceb8287f9fb657eda48ff8fcfe7
Author: Peter Zijlstra <a.p.zijlstra@xxxxxxxxx>
Date: Tue Apr 5 17:23:39 2011 +0200

sched: Provide scheduler_ipi() callback in response to smp_send_reschedule()

I did partial backport of above to come up with a fix for rhel6 and put
your first patch on top of it.

Once your current patches get merged, I can backport above and two of
your patches for older kernel is there is interest.

Thanks
Vivek
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/