Re: [PATCH 4/6] udf: Convert printks to pr_<level>

[Joe Perches]

On Mon, 2011-10-10 at 16:59 +0200, Jan Kara wrote:
> On Mon 10-10-11 01:08:05, Joe Perches wrote:
> > Use the current logging styles.
> > Convert a few printks that should have been udf_warn and udf_err.
> > Coalesce formats.  Add #define pr_fmt.
> > Move an #include "udfdecls.h" above other includes in udftime.c
> > so pr_fmt works correctly.  Strip prefixes from conversions as appropriate.
> > Reorder logging definitions in udfdecl.h
>   Any reason why you didn't use udf_err() / udf_warn() in all the places
> where sb pointer is available?

I did it in the places where sb was otherwise used
in the output message.

> Also I'd further use udf_err() in
> udf_parse_options() - passing sb there is simple and additional information
> in the message is useful. Thanks.

Maybe NamJae can do that in a follow-on patch.

NamJae, I broke up your larger patch so you could
see an example of the preferred form of smaller,
targeted patches.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/