[PATCH 4/4] staging: et131x: Update TODO list

From: Mark Einon
Date: Mon Oct 10 2011 - 11:24:07 EST


Added some more tasks to the TODO list, as highlighted by Francois
Romieu <romieu@xxxxxxxxxxxxx>.

Signed-off-by: Mark Einon <mark.einon@xxxxxxxxx>
---
drivers/staging/et131x/README | 9 +++++++--
1 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/et131x/README b/drivers/staging/et131x/README
index d383e80..c67f83e 100644
--- a/drivers/staging/et131x/README
+++ b/drivers/staging/et131x/README
@@ -2,13 +2,18 @@ This is a driver for the ET1310 network device.

Based on the driver found at https://sourceforge.net/projects/et131x/

-Cleaned up immensely by Olaf Hartman and Christoph
-Hellwig <hch@xxxxxxxxxxxxx>
+Cleaned up immensely by Olaf Hartman and Christoph Hellwig <hch@xxxxxxxxxxxxx>

Note, the powermanagement options were removed from the vendor provided
driver as they did not build properly at the time.

TODO:
+ - Put the driver into a single file, with a .h for the registers layout.
+ - rx_ring.fbr{0, 1} can probably share a common structure
+ - Use of kmem_cache seems a bit unusual
+ - Use dma_alloc_... in place of pci_alloc_...
+ - It's too late stopping the tx queue when there is no room for the current packet. The condition should be detected for the next packet.
+ - PCI_VDEVICE ?

Please send patches to:
Greg Kroah-Hartman <gregkh@xxxxxxx>
--
1.7.6.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/