Re: [PATCH] fix ehci alignment error

From: Alan Stern
Date: Mon Oct 10 2011 - 11:28:10 EST


On Mon, 10 Oct 2011, Harro Haan wrote:

> The Kirkwood gave an unaligned memory access error on
> line 742 of drivers/usb/host/echi-hcd.c:
> "ehci->last_periodic_enable = ktime_get_real();"
>
> Signed-off-by: Harro Haan <hrhaan@xxxxxxxxx>
> ---
> include/linux/usb/hcd.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/include/linux/usb/hcd.h b/include/linux/usb/hcd.h
> index 0097136..c0ecc5a 100644
> --- a/include/linux/usb/hcd.h
> +++ b/include/linux/usb/hcd.h
> @@ -178,7 +178,7 @@ struct usb_hcd {
> * this structure.
> */
> unsigned long hcd_priv[0]
> - __attribute__ ((aligned(sizeof(unsigned long))));
> + __attribute__ ((aligned(sizeof(s64))));
> };
>
> /* 2.4 does this a bit differently ... */

Acked-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/