Re: [PATCH 1/5 v13] arm: omap: usb: ehci and ohci hwmod structuresfor omap4

[Alan Stern]

On Mon, 10 Oct 2011, Felipe Balbi wrote:

> On Mon, Oct 10, 2011 at 11:19:43AM -0400, Alan Stern wrote:
> > On Mon, 10 Oct 2011, Felipe Balbi wrote:
> > 
> > > > > do we have sibling structures today? I dont think so.
> > > > 
> > > > no we don't.
> > > 
> > > Ok, here's a first shot at it:
> > 
> > In fact we do already have sibling lists.  They are maintained as part 
> > of the device_private structure.  What we are missing is a 
> > device_for_each_sibling() routine.  It could be added pretty easily; it 
> > would be similar to device_for_each_child().
> 
> care to point out where is ?
> 
> 68 struct device_private {
> 69         struct klist klist_children;
> 70         struct klist_node knode_parent;
-------------^  Here.  The "parent" in the name refers to where the
                head of the list is stored.

> 71         struct klist_node knode_driver;
> 72         struct klist_node knode_bus;
> 73         void *driver_data;
> 74         struct device *device;
> 75 };

>From device_add():

	if (parent)
		klist_add_tail(&dev->p->knode_parent,
			       &parent->p->klist_children);

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/