Re: [PATCH v6 3/8] foundations of per-cgroup memory pressure controlling.

[Glauber Costa]

On 10/13/2011 09:53 AM, KAMEZAWA Hiroyuki wrote:
> On Mon, 10 Oct 2011 14:24:23 +0400
> Glauber Costa<glommer@xxxxxxxxxxxxx>  wrote:
>
> > This patch converts struct sock fields memory_pressure,
> > memory_allocated, sockets_allocated, and sysctl_mem (now prot_mem)
> > to function pointers, receiving a struct mem_cgroup parameter.
> >
> > enter_memory_pressure is kept the same, since all its callers
> > have socket a context, and the kmem_cgroup can be derived from
> > the socket itself.
> >
> > To keep things working, the patch convert all users of those fields
> > to use acessor functions.
> >
> > In my benchmarks I didn't see a significant performance difference
> > with this patch applied compared to a baseline (around 1 % diff, thus
> > inside error margin).
> >
> > Signed-off-by: Glauber Costa<glommer@xxxxxxxxxxxxx>
> > CC: David S. Miller<davem@xxxxxxxxxxxxx>
> > CC: Hiroyouki Kamezawa<kamezawa.hiroyu@xxxxxxxxxxxxxx>
> > CC: Eric W. Biederman<ebiederm@xxxxxxxxxxxx>
>
> Reviewed-by: KAMEZAWA Hiroyuki<kamezawa.hiroyu@xxxxxxxxxxxxxx>
>
> a nitpick.
>
>
> >   #ifdef CONFIG_INET
> > +enum {
> > +	UNDER_LIMIT,
> > +	OVER_LIMIT,
> > +};
> > +
>
> It may be better to move this to res_counter.h or memcontrol.h
Sorry Kame,

It is in memcontrol.h already. What exactly do you mean here ?



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/