Re: [PATCH] staging:iio:proof of concept in kernel interface.

[Jonathan Cameron]

On 10/13/11 15:32, Mark Brown wrote:
> On Tue, Oct 11, 2011 at 12:43:03PM +0100, Jonathan Cameron wrote:
> 
>> +struct iio_dev *iio_find_dev(const char *name);
>> +void iio_release_dev(struct iio_dev *indio_dev);
> 
> This looks like it should really be clk style with a struct device and a
> back end interface that deals with mapping the provider to consumers at
> runtime.
Agreed.  That definitely looks like the best discovery interface
out there at the moment.  Will reroll with the equivalent.

We'll have to play a few games in the drivers to map back to the underlying
bus names so that we have consistent naming.  (simple callback).
> 
>> +	/* read from channel 1 and exit */
>> +	ret = indio_dev->info->read_raw(indio_dev, &indio_dev->channels[0], &val, &val2, 0);
> 
> I guess an actual implementation would have wrappers for doing the
> indirections rather than having users peer into the ops table directly?
> 
Yup, for some reason the cover letter seems to have detached from this.
It suggested exactly that.  There may be weird cases where peering this
deep into the ops makes sense, but not for something like this one.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/