Re: [PATCH 1/3] ASoC: alc5623: Convert codec->hw_read to regmap_read

From: Mark Brown
Date: Thu Oct 13 2011 - 12:51:33 EST


On Thu, Oct 13, 2011 at 03:22:55PM +0800, Axel Lin wrote:
> codec->hw_read is broken now, let's covert to regmap_read.
>
> Signed-off-by: Axel Lin <axel.lin@xxxxxxxxx>

I'd rather not fix these like this because when we convert these drivers
to use regmap directly it won't be quite so obvious what's going on and
we'll easily introduce bugs where we start using the cached values from
a regmap level cache.

Probably the best thing here is to convert all these drivers to use
cache_bypass to read directly through the cache - the same thing will
then work with direct regmap usage.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/