Re: [PATCH] PCI / PM: Remove unnecessary error variable fromacpi_dev_run_wake()

From: Jesse Barnes
Date: Fri Oct 14 2011 - 12:08:09 EST


On Wed, 28 Sep 2011 21:44:36 +0200
"Rafael J. Wysocki" <rjw@xxxxxxx> wrote:
> ---
> From: Rafael J. Wysocki <rjw@xxxxxxx>
> Subject: PCI / PM: Return correct result from acpi_dev_run_wake()
>
> The result returned by acpi_dev_run_wake() is always either -EINVAL
> or -ENODEV, while obviously it should return 0 on success. The
> problem is that the leftover error variable, that's not really used
> in the function, is initialized with -ENODEV and then returned
> without modification.
>
> To fix this issue remove the error variable from acpi_dev_run_wake()
> and make the function return 0 on success as appropriate.
>
> Signed-off-by: Rafael J. Wysocki <rjw@xxxxxxx>

Applied to linux-next, thanks.

--
Jesse Barnes, Intel Open Source Technology Center

Attachment: signature.asc
Description: PGP signature