Re: [PATCH v2.1 1/7] crypto: GnuPG based MPI lib - source files (part 1)

From: David Howells
Date: Mon Oct 17 2011 - 11:52:13 EST


James Morris <jmorris@xxxxxxxxx> wrote:

> > +MPI mpi_alloc(unsigned nlimbs)
> > +{
> > + MPI a;
> > +
> > + a = (MPI) kmalloc(sizeof *a, GFP_KERNEL);
>
> Generally, typedef structs are frowned upon in the kernel. I'd prefer to
> see this (and any others) changed to a normal type.

In this case, however, it makes it easier to compare back to the original
code.

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/