Re: [PATCH] x86: mpparse: fix mp_bus_not_pci handling

[Jonathan Nieder]

Bjorn Helgaas wrote:
> On Sun, Sep 25, 2011 at 3:29 PM, Bjorn Helgaas <bhelgaas@xxxxxxxxxx> wrote:

>> Dan bisected a Dell PowerEdge 4200 boot regression to commit f8924e770.
>> Prior to that commit, 32-bit kernels set mp_bus_not_pci for all buses
>> except PCI. ÂAfterwards, we set mp_bus_not_pci only for ISA. ÂBut ISA is
>> not the only non-PCI bus, so it's better to always set mp_bus_not_pci
>> and clear it only for PCI.
[...]
>> +++ b/arch/x86/kernel/mpparse.c
>> @@ -95,8 +95,8 @@ static void __init MP_bus_info(struct mpc_bus *m)
[...]
>> + Â Â Â set_bit(m->busid, mp_bus_not_pci);
>> Â Â Â Âif (strncmp(str, BUSTYPE_ISA, sizeof(BUSTYPE_ISA) - 1) == 0) {
>> - Â Â Â Â Â Â Â set_bit(m->busid, mp_bus_not_pci);
[...]
> Ping?  I don't see this in linux-next, so I don't know if it got
> dropped or if there's something wrong with it.

For what it's worth (not much, of course):

 Reviewed-by: Jonathan Nieder <jrnieder@xxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/