Re: [PATCH -V7 21/26] richacl: xattr mapping functions

From: J. Bruce Fields
Date: Wed Oct 19 2011 - 18:21:15 EST


On Tue, Oct 18, 2011 at 09:02:56PM +0530, Aneesh Kumar K.V wrote:
> +#define RICHACL_XATTR "system.richacl"
> +
> +struct richace_xattr {
> + __le16 e_type;
> + __le16 e_flags;
> + __le32 e_mask;
> + __le32 e_id;
> + char e_who[0];
> +};

Does it really make sense to use a string here just to pick between the
three choices OWNER@, GROUP@, and EVERYONE@? Why not just another small
integer? Is the goal to expand this somehow eventually?

--b.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/