Re: [PATCH 2/4] fbdev/cirrusfb: Rewrite Zorro graphics card probing

From: Jeff Garzik
Date: Thu Oct 20 2011 - 13:03:13 EST


On 10/20/2011 07:42 AM, Geert Uytterhoeven wrote:
As indicated by commit a7f4d00a82feb5b311f765bf9522bc55bee0684f ("zorro:
Defer device_register() until all devices have been identified"), cirrusfb
crashes if zorro_find_device() cannot find an expected device.

Rewrite the Zorro device probe code to make it more robust, easier to
understand, and more extensible.

Other logical changes:
- For cards that show up as 2 Zorro devices, autoprobe graphics memory
sizes based on the size of the Zorro device containing the graphics
memory.
Acording to the NetBSD sources, this is safe.

Signed-off-by: Geert Uytterhoeven<geert@xxxxxxxxxxxxxx>

Acked-by: Jeff Garzik <jgarzik@xxxxxxxxxx>



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/