Re: [PATCH 2/2] blk-throttle: Take blkcg->lock while traversingblkcg->policy_list

From: Tejun Heo
Date: Thu Oct 20 2011 - 17:11:45 EST


Hello,

On Thu, Oct 20, 2011 at 05:08:26PM -0400, Vivek Goyal wrote:
> blkcg->policy_list is protected by blkcg->lock. Its not rcu protected
> list. So even for readers, they need to take blkcg->lock. There are
> few functions which were reading the list without taking lock. Fix it.
>
> Signed-off-by: Vivek Goyal <vgoyal@xxxxxxxxxx>

Acked-by: Tejun Heo <tj@xxxxxxxxxx>

And yeap, some of rcu usages in cfq/iocg seem either incorrect or
unnecessary. Trying to clean up that now too.

Thank you.

--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/