Re: [PATCH] SCSI, pmcraid: Fix kmalloc() argument order inpmcraid_chr_ioctl()

[Jesper Juhl]

On Mon, 24 Oct 2011, Dave Jones wrote:

> On Tue, Oct 25, 2011 at 12:50:08AM +0200, richard -rw- weinberger wrote:
>  
>  > BTW: What about a checkpatch.pl rule to detect such a misuse of kmalloc()?
>  > We could grep for "k[mzc]alloc(GFP_".
> 
> Make sure to ignore bio_kmalloc (which has reverse argument order to kmalloc, ugh)
> 
Yeah, and there's also kmalloc_node() (and perhaps kmem_cache_alloc() && 
kmem_cache_alloc_node() although there the compiler will at least warn) 
that might as well be checked for.

-- 
Jesper Juhl <jj@xxxxxxxxxxxxx>       http://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/