Re: [PATCH] SCSI, pmcraid: Fix kmalloc() argument order in pmcraid_chr_ioctl()

From: richard -rw- weinberger
Date: Mon Oct 24 2011 - 19:03:38 EST


On Tue, Oct 25, 2011 at 12:54 AM, Dave Jones <davej@xxxxxxxxxx> wrote:
> On Tue, Oct 25, 2011 at 12:50:08AM +0200, richard -rw- weinberger wrote:
>
>  > BTW: What about a checkpatch.pl rule to detect such a misuse of kmalloc()?
>  > We could grep for "k[mzc]alloc(GFP_".
>
> Make sure to ignore bio_kmalloc (which has reverse argument order to kmalloc, ugh)
>

Hmmm, maybe we should "fix" the argument order of bio_kmalloc().
But as this function is exported we'd silently break some out-of-tree
kernel modules....

--
Thanks,
//richard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/