Re: linux-next: build failure after merge of the pci tree

[Myron Stowe]

On Wed, 2011-10-26 at 00:44 +1100, Stephen Rothwell wrote:
> Hi Jesse,
> 
> After merging the pci tree, today's linux-next build (powerpc
> pseries_defconfig) failed like this:
> 
> drivers/pci/pci.c:2605: error: redefinition of 'pcibios_set_master'
> arch/powerpc/include/asm/pci.h:49: note: previous definition of
> 'pcibios_set_master' was here
> 
> Presumably caused by commit 481da3e3d53e ("PCI: Pull PCI 'latency
> timer'
> setup up into the core").
> 
Yes, commit 481da3e3d53e is the culprit here.  I was trying to not
modify architectures that had inline nop functions but it's now obvious
that the compiler sees the architecture specific include files before it
sees the __weak def I added in drivers/pci/pci.c

I think the best approach here is to remove the inline versions of
pcibios_set_master() for the architectures with inline nops.  This will
effectively add the new generic code to those architectures; which will
be a slight change in behavior for them.  This has the benefit of ending
up with most architectures utilizing the new generic code and only those
that absolutely must having specific versions of pcibios_set_master()
that over-rides the generic __weak code.  If we encounter issues going
forward with this approach for a specific architecture then we can add a
non-weak empty version back in for it.

If anyone has issues with such an approach please let me know.  In the
mean time -

I'll work on modifying the patch series accordingly.

Jesse: can you drop the series from pci-2.6/linux-next and I'll re-post
with v2?

Stephen: do you need me to do anything here or can you also drop the
series from linux-next?

Myron

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/