Re: [PATCH 10/13] block, cfq: unlink cfq_io_context's immediately

[Tejun Heo]

Hello,

On Wed, Oct 26, 2011 at 03:48:57PM -0400, Vivek Goyal wrote:
> > +		ioc_release_depth_inc(cic->q);
> > +		cic->exit(cic);
> > +		cic->release(cic);
> > +		ioc_release_depth_dec(cic->q);
> 
> cic->release(cic) can free the cic? Are we accessing cic after freeing it
> up in ioc_release_depth_dec(cic->q);

As cic is RCU freed and we're running w/ irq disabled, this shouldn't
blow up, but yeah, I'll update it to use local variable instead.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/