Re: [PATCH 2/2] pinmux: Unify pin type from signed to unsigned.

From: David Rientjes
Date: Wed Oct 26 2011 - 17:06:25 EST


On Wed, 26 Oct 2011, Marek Belisko wrote:

> diff --git a/include/linux/pinctrl/pinctrl.h b/include/linux/pinctrl/pinctrl.h
> index 3605e94..34c33c7 100644
> --- a/include/linux/pinctrl/pinctrl.h
> +++ b/include/linux/pinctrl/pinctrl.h
> @@ -112,7 +112,7 @@ struct pinctrl_desc {
> extern struct pinctrl_dev *pinctrl_register(struct pinctrl_desc *pctldesc,
> struct device *dev, void *driver_data);
> extern void pinctrl_unregister(struct pinctrl_dev *pctldev);
> -extern bool pin_is_valid(struct pinctrl_dev *pctldev, int pin);
> +extern bool pin_is_valid(struct pinctrl_dev *pctldev, unsigned int pin);
> extern void pinctrl_add_gpio_range(struct pinctrl_dev *pctldev,
> struct pinctrl_gpio_range *range);
> extern void pinctrl_remove_gpio_range(struct pinctrl_dev *pctldev,
> @@ -123,7 +123,7 @@ extern void *pinctrl_dev_get_drvdata(struct pinctrl_dev *pctldev);
>
>
> /* Sufficiently stupid default function when pinctrl is not in use */
> -static inline bool pin_is_valid(struct pinctrl_dev *pctldev, int pin)
> +static inline bool pin_is_valid(struct pinctrl_dev *pctldev, unsigned int pin)
> {
> return pin >= 0;
> }


So this would just become return true, right?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/