Re: [PATCH] staging: bcm: Fixed major coding style issues

[Greg KH]

On Wed, Oct 26, 2011 at 05:52:40PM -0500, Matthew Piehl wrote:
> Fixed major coding style issues and removed all checkpatch errors and
> and many warnings.

You just did a whole lot of things all in one patch, making it very hard
to review.

Please break it up into one-patch-per-logical-change, and no, "fix
everything" is not a single logical change :)

Also, please check Linus's current tree to see if this even applies, I
don't want you to do work that's already been done as that would be sad.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/