Re: [PATCH 02/15] ATA : vortex86 : fix vortex86dx/sx hardware CRCbug.

From: Alan Cox
Date: Thu Oct 27 2011 - 03:53:39 EST


On Tue, 25 Oct 2011 23:16:04 -0500
Paul Schilling <paul.s.schilling@xxxxxxxxx> wrote:

> This fixes a DMA issue related to a CRC bug on
> the RDC pata peripherial found on the vortex86sx and vortex86dx.

What is the RDC erratum reference for this ? Also it seems to make no
sense


> static const struct ata_port_info info_rdc_11 = {
> .flags = ATA_FLAG_SLAVE_POSS,
> .pio_mask = ATA_PIO4,
> - .mwdma_mask = ATA_MWDMA2,
> + .mwdma_mask = 0,
> + .udma_mask = 0,

MWDMA is not part of the CRC hardware anyway

Are you sure these newer variants are simply not using a different set of
timing parameters thus showing bugs on your system ?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/