Re: fs: jdb/jbd2: Put identical code in a common header
From: Ted Ts'o
Date: Thu Oct 27 2011 - 05:13:36 EST
On Tue, Oct 18, 2011 at 10:40:31PM +0200, Jan Kara wrote:
> On Wed 05-10-11 13:29:29, Thomas Gleixner wrote:
> > The state bits and the lock functions of jbd and jbd2 are
> > identical. Share them.
> Hum, Ted, I don't think this got picked up. What's your opinion?
It seems reasonable to me. Factoring out common code is a good
though, although inline functions won't save any text space and since
this part of the jbd header files are rarely changed, so the
maintainability advantages are reduced.
I'll take the patch and include it in the ext4 tree.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/