RE: [PATCH] PM: fix calculation mistake in roll-over cases

[Venu Byravarasu]

> -----Original Message-----
> From: Alan Stern [mailto:stern@xxxxxxxxxxxxxxxxxxx]
> Sent: Friday, October 28, 2011 12:00 AM
> To: Venu Byravarasu
> Cc: Rafael J. Wysocki; pavel@xxxxxx; len.brown@xxxxxxxxx; gregkh@xxxxxxx;
> linux-pm@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Peter De Schrijver
> Subject: RE: [PATCH] PM: fix calculation mistake in roll-over cases
> 
> On Thu, 27 Oct 2011, Venu Byravarasu wrote:
> 
> > > From: venu byravarasu <vbyravarasu@xxxxxxxxxx>
> > >
> > > In case of jiffies roll over, delta is made zero.
> > > Hence fixing it, after taking roll over into consideration.
> > >
> > > Signed-off-by: venu byravarasu <vbyravarasu@xxxxxxxxxx>
> > > ---
> 
> > 2. Even if delta is made unsigned, in cases of jiffies roll over, delta will be zero.
> > That is also being taken care with the code added as part of if condition.
> 
> Since delta is now unsigned, the "if (delta < 0)" test can never
> succeed.  Therefore it can be removed.
> 
> The new lines you added with max_num don't seem to serve any useful
> purpose.  All they do is recalculate the same value that delta had
> before, but with an off-by-one error.
> 
Agree with you Alan.
Will remove max_num references and upload the change.

Thanks,
Venu
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/