Re: [PATCH v7 0/7] SUNRPC: make rpcbind clients allocated anddestroyed dynamically
From: J. Bruce Fields
Date: Fri Oct 28 2011 - 10:27:15 EST
On Fri, Oct 28, 2011 at 02:52:09PM +0300, Stanislav Kinsbursky wrote:
> This patch-set was created in context of clone of git branch:
> and rebased on tag "v3.1".
> 1) Implemented "goto pattern" in __svc_create().
> 2) Pathes 5 and 6 from perious patch-set were squashed to make things looks
> clearer and to allow safe bisecting of the patch-set.
This series looks fine to me; thanks!
> 1) Fixes in rpcb_clients management.
> 1) creation and destruction on rpcbind clients now depends on service program
> versions "vs_hidden" flag.
> This patch is required for further RPC layer virtualization, because rpcbind
> clients have to be per network namespace.
> To achive this, we have to untie network namespace from rpcbind clients sockets.
> The idea of this patch set is to make rpcbind clients non-static. I.e. rpcbind
> clients will be created during first RPC service creation, and destroyed when
> last RPC service is stopped.
> With this patch set rpcbind clients can be virtualized easely.
> The following series consists of:
> Stanislav Kinsbursky (7):
> SUNRPC: introduce helpers for reference counted rpcbind clients
> SUNRPC: use rpcbind reference counting helpers
> SUNRPC: introduce svc helpers for prepairing rpcbind infrastructure
> SUNRPC: setup rpcbind clients if service requires it
> SUNRPC: cleanup service destruction
> SUNRPC: remove rpcbind clients creation during service registering
> SUNRPC: remove rpcbind clients destruction on module cleanup
> fs/nfsd/nfssvc.c | 2 +
> include/linux/sunrpc/clnt.h | 2 +
> include/linux/sunrpc/svc.h | 1
> net/sunrpc/rpcb_clnt.c | 88 ++++++++++++++++++++++++++++---------------
> net/sunrpc/sunrpc_syms.c | 3 -
> net/sunrpc/svc.c | 57 ++++++++++++++++++++++++----
> 6 files changed, 113 insertions(+), 40 deletions(-)
> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/