Re: [patch] drm/i915: fix if statement (bogus semi-colon)

From: Chris Wilson
Date: Fri Oct 28 2011 - 13:20:29 EST


On Fri, 28 Oct 2011 10:10:26 -0700, Keith Packard <keithp@xxxxxxxxxx> wrote:
> On Fri, 28 Oct 2011 14:42:41 +0300, Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:
>
> > - if (needs_idle_maps());
> > + if (needs_idle_maps())
>
> how embarrassing is that?

Actually it served an ulterior purpose and by exercising the workaround
showed us that it contained a more subtle bug. I believe therefore Ben
did it deliberately ;-)
-Chris

--
Chris Wilson, Intel Open Source Technology Centre
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/