Re: [RFC PATCH] freezer: revert 27920651fe "PM / Freezer: Makefake_signal_wake_up() wake TASK_KILLABLE tasks too"
From: Tejun Heo
Date: Mon Oct 31 2011 - 19:17:37 EST
On Mon, Oct 31, 2011 at 03:17:43PM -0700, Tejun Heo wrote:
> Commit 27920651fe "PM / Freezer: Make fake_signal_wake_up() wake
> TASK_KILLABLE tasks too" made freezer wake up tasks in TASK_KILLABLE
> sleep too citing non-interruptible but killable sleeps in cifs and
> I don't think we can do this. We should not send spurious unsolicited
> non-interruptible wakeups. Most synchornization constructs are built
> to cope with spurious wakeups and any INTERRUPTIBLE sleep must be able
> to handle spurious wakeups but that's not true for KILLABLE sleeps -
> KILLABLE condition cannot be cancelled.
> This is probably okay for most cases but circumventing fundamental
> wakeup condition like this is asking for trouble. Furthermore, I'm
> not sure the behavior change brought on by this change - breaking
> nfs/cifs uninterruptible operation guarantee - is correct. If such
> behavior is desirable, the right thing to do is using intr mount
> option, not circumventing it from PM layer.
> Signed-off-by: Tejun Heo <tj@xxxxxxxxxx>
> Cc: Jeff Layton <jlayton@xxxxxxxxxx>
> Neil, Steve, do the network filesystems need a way to indicate "I can
> either be killed or enter freezer"?
Hmm... okay, so commit f06ac72e929 "cifs, freezer: add
wait_event_freezekillable and have cifs use it" added freezable &
killable sleep. If this is necessary, the right thing to do is adding
another waking state, not modifying existing one's behavior.
But, before going there, is this *really* necessary? Do we really
have to choose among different combinations of interruptible, killable
and freezable? If something doesn't want to be bothered than being
killed, assuming it doesn't want to go hibernating is kinda natural.
IOW, can we please update cifs, if it wants to allow hibernation, to
use interruptible sleep in wait_for_response() than trying to modify
basic sleep mechanism?
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/