re: [SCSI] compat_ioct: fix bsg SG_IO

From: Dan Carpenter
Date: Wed Nov 02 2011 - 04:16:33 EST


84eb8fb42c120 "[SCSI] compat_ioct: fix bsg SG_IO" introduces an
uninitialized variable use.

278 static int sg_ioctl_trans(unsigned int fd, unsigned int cmd,
279 sg_io_hdr32_t __user *sgio32)
280 {
281 sg_io_hdr_t __user *sgio;
282 u16 iovec_count;
283 u32 data;
284 void __user *dxferp;
285 int err;
286 int interface_id;
287
288 if (get_user(interface_id, &sgio32->interface_id))
^^^^^^
sgio32 is unitialized here. Unfortunately Gcc doesn't warn about it.

289 return -EFAULT;
290 if (interface_id != 'S')
291 return sys_ioctl(fd, cmd, (unsigned long)sgio32);

regards,
dan carpenter

Attachment: signature.asc
Description: Digital signature