Re: [PATCHv4 4/6] input/cma3000_d0x: Add CMA3000 spi support

From: Ricardo Ribalda Delgado
Date: Wed Nov 02 2011 - 08:39:11 EST


Hello Mark

I will wait until your patches arrive to linux-next. And then I will
port mine in top of yours. It will be great to get your feedback then.
Thanks!

On Tue, Oct 25, 2011 at 10:36, Mark Brown
<broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote:
> On Tue, Oct 25, 2011 at 09:32:27AM +0100, Jonathan Cameron wrote:
>> On 10/25/11 08:24, Ricardo Ribalda Delgado wrote:
>
>> > It is not on linux-next, and also it cannot be used directly, in order
>> > to read you have to do set reg= (reg << 2) | 2; And AFAIK it is not
>> > supported by the regmap
>
>> My gut feeling is it would easy enough to add if it can't currently
>> be done. Mark?
>
> That should be trivial to add - the | 2 bit is already supported in
> -next and will be sent to Linus this merge window, adding the shift is
> just a simple matter of programming.
>
>> Gains here are leveraging the bus abstractions from there.  There aren't
>> enough registers to gain from caching etc.
>
> Depends on the workload more than the number of registers - if you're
> able to eliminate enough reads then it can give a bit of a performance
> boost.  But it's completely optional either way.
>



--
Ricardo Ribalda
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/