Re: [PATCH v2] staging/xgifb: Convert pci_table entries toPCI_DEVICE (if PCI_ANY_ID is used)

[Dan Carpenter]

On Sun, Nov 06, 2011 at 11:12:28PM +0100, Peter Huewe wrote:
> This patch converts pci_table entries to use the PCI_DEVICE macro,
> if .subvendor and .subdevice are set to PCI_ANY_ID,
> and thus improves readability.
> 
> v2:
> Since the driver_data field isn't used anywhere we can also drop the
> assignments for class, class_mask and driver_data.
> (found by Aaro Koskinen)
> 
> KernelVersion: Staging-20111106

Don't put that into the permanent changelog.

Sometimes we ask people what tree they wrote a patch against, but the
truth is that we don't actually care.

Q: Your patch doesn't apply.  Which tree did you do it against?
A: Blah blah blah long explanation.
Q: Oh that's very nice and lovely.  Please redo it against today's
   -next tree.

For bug fixes where it could go into either the current kernel or the
next, then it is nice to say.  Normally people want a [patch -next
v2] in the subject which will get removed by git am.  Or below the
--- dashes.

regards,
dan carpenter

Attachment: signature.asc
Description: Digital signature