Re: [PATCH] oom: do not kill tasks with oom_score_adjOOM_SCORE_ADJ_MIN

From: David Rientjes
Date: Mon Nov 07 2011 - 16:54:42 EST


On Fri, 4 Nov 2011, Michal Hocko wrote:

> diff --git a/mm/oom_kill.c b/mm/oom_kill.c
> index e916168..4883514 100644
> --- a/mm/oom_kill.c
> +++ b/mm/oom_kill.c
> @@ -185,6 +185,9 @@ unsigned int oom_badness(struct task_struct *p, struct mem_cgroup *mem,
> if (!p)
> return 0;
>
> + if (p->signal->oom_score_adj == OOM_SCORE_ADJ_MIN)
> + return 0;
> +
> /*
> * The memory controller may have a limit of 0 bytes, so avoid a divide
> * by zero, if necessary.

This leaves p locked, you need to do task_unlock(p) first.

Once that's fixed, please add my

Acked-by: David Rientjes <rientjes@xxxxxxxxxx>

and resubmit to Andrew for the 3.2 rc series. Thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/