Re: Linux 3.2-rc1

From: Linus Torvalds
Date: Tue Nov 08 2011 - 15:13:40 EST


On Tue, Nov 8, 2011 at 6:53 AM, Alessandro Suardi
<alessandro.suardi@xxxxxxxxx> wrote:
>
> Dell laptop support (and I'd suspect other drivers using LED support)
>  doesn't build with undefined LED-related functions, as in:
>
> ERROR: "led_classdev_unregister" [drivers/platform/x86/dell-laptop.ko]
> undefined!
> ERROR: "led_classdev_register" [drivers/platform/x86/dell-laptop.ko] undefined!
> make[1]: *** [__modpost] Error 1
> make: *** [modules] Error 2
>
> It's enough to configure NEW_LEDS (unneeded in 3.1.0) to allow the build to go
>  through; maybe NEW_LEDS should be auto-selected in Kconfig by drivers that
>  make use of led_classdev_* functions ?

Yeah, that sounds like the right fix. There are a lot of "select
NEW_LEDS" around already, but apparently not the Dell driver.

Matthew?

Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/