Re: [PATCH] drm: avoid switching to text console if there is no panic timeout

From: Dave Airlie
Date: Thu Nov 10 2011 - 16:29:18 EST


On Thu, Nov 10, 2011 at 9:15 PM, Mandeep Singh Baines <msb@xxxxxxxxxxxx> wrote:
> David Rientjes (rientjes@xxxxxxxxxx) wrote:
>> On Mon, 17 Oct 2011, David Rientjes wrote:
>>
>> > On Mon, 17 Oct 2011, Mandeep Singh Baines wrote:
>> >
>> > > From: Hugh Dickins <hughd@xxxxxxxxxxxx>
>> > >
>> > > Add a check for panic_timeout in the drm_fb_helper_panic() notifier: if
>> > > we're going to reboot immediately, the user will not be able to see the
>> > > messages anyway, and messing with the video mode may display artifacts,
>> > > and certainly get into several layers of complexity (including mutexes and
>> > > memory allocations) which we shall be much safer to avoid.
>> > >
>> > > Signed-off-by: Hugh Dickins <hughd@xxxxxxxxxx>
>> > > [ Edited commit message and modified to short-circuit panic_timeout < 0
>> > >   instead of testing panic_timeout >= 0.  -Mandeep ]
>> > > Signed-off-by: Mandeep Singh Baines <msb@xxxxxxxxxxxx>
>> > > Cc: Dave Airlie <airlied@xxxxxxxxxx>
>> > > Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
>> > > Cc: dri-devel@xxxxxxxxxxxxxxxxxxxxx
>> >
>> > Acked-by: David Rientjes <rientjes@xxxxxxxxxx>
>> >
>>
>> Dave, where do we stand on this?  I haven't seen it hit Linus' tree and I
>> don't see it in git://people.freedesktop.org/~airlied/linux.

I've just pulled it into my local drm-next, thanks for reminding me.

Dave.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/