Re: [PATCH] mfd: twl4030-audio: Fix audio codec breakage

From: Jarkko Nikula
Date: Fri Nov 11 2011 - 03:46:40 EST


On 11/02/2011 09:41 AM, Péter Ujfalusi wrote:
On Wednesday 19 October 2011 11:44:05 Jarkko Nikula wrote:
Commit 57fe725 ("MFD: twl4030-codec -> twl4030-audio: Rename the driver")
broke the device registration for twl4030 codec if twl6040 is not set.

Reason for breakage is that commit didn't update the changed config name for
macro twl_has_codec().

Signed-off-by: Jarkko Nikula<jarkko.nikula@xxxxxxxxxx>
Cc: Peter Ujfalusi<peter.ujfalusi@xxxxxx>
---
I don't know is this too late for 3.1 or would it be better to queue for
stable when it's out? Anyway breakage happened in 3.1-rc cycle and
unfortunately I noticed it only now.

Thanks Jarkko for noticing this. I have overlooked it probably because I'm
using omap2plus_defconf for most of the time.

The breakage also present in 3.0. Can we queue this patch for stable 3.0.x,
and 3.1.x?

Acked-by: Peter Ujfalusi<peter.ujfalusi@xxxxxx>

Actually this is already fixed by f09ee04 ("mfd: Fix twl4030 dependencies for audio codec") which is now in 3.2-rc. Is that commit queued for stable too?

--
Jarkko
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/