Re: [PATCH] s3c-adc-battery: Add naive POWER_SUPPLY_PROP_PRESENT implementation

[Heiko StÃbner]

Am Donnerstag, 10. November 2011, 14:30:52 schrieb Anton Vorontsov:
> On Thu, Nov 10, 2011 at 02:05:06PM +0300, Vasily Khoruzhick wrote:
> > On Thu, 2011-11-10 at 09:56 +0100, Heiko StÃbner wrote:
> > > Userspace programs like upower seem to depend on the presence of the
> > > POWER_SUPPLY_PROP_PRESENT property.
> > > 
> > > The real presence of the battery cannot be sensed and all other
> > > routines of s3c-adc-battery simply expect it to be present.
> > > 
> > > Therefore we simply return 1, unless the battery struct is not present
> > > at all.
> > 
> > Looks OK for me,
> > 
> > > Signed-off-by: Heiko Stuebner <heiko@xxxxxxxxx>
> > 
> > Acked-by: Vasily Khoruzhick <anarsoul@xxxxxxxxx>
> 
> I disagree. If the driver behaves like the hardware does not support
> hot-pluggable cells, then present property is not necessary.
> 
> Upowerd should look at the 'present' only if it is there; and if it
> is not, cells assumed to be always present.

[..]
 
> So, the problem is in upowerd, not this driver.

Thanks for your comment. I will therefore take this matter up with the upower-
guys.

Thanks
Heiko
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/