Re: [PATCH FIX net v2] forcedeth: fix stats on hardware withoutextended stats support

From: David Miller
Date: Mon Nov 14 2011 - 00:15:46 EST


From: David Decotigny <david.decotigny@xxxxxxxxxx>
Date: Fri, 11 Nov 2011 18:27:34 -0800

> This change makes sure that tx_packets/rx_bytes ifconfig counters are
> updated even on NICs that don't provide hardware support for these
> stats: they are now updated in software. For the sake of consistency,
> we also now have tx_bytes updated in software (hardware counters
> include ethernet CRC, and software doesn't account for it).
>
> This reverts parts of:
> - "forcedeth: statistics optimization" (21828163b2)
> - "forcedeth: Improve stats counters" (0bdfea8ba8)
> - "forcedeth: remove unneeded stats updates" (4687f3f364)
>
> Tested:
> pktgen + loopback (http://patchwork.ozlabs.org/patch/124698/)
> reports identical tx_packets/rx_packets and tx_bytes/rx_bytes.
>
> Signed-off-by: David Decotigny <david.decotigny@xxxxxxxxxx>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/