Re: [PATCH] net/packet: remove dead code and unneeded variable fromprb_setup_retire_blk_timer()

[Jesper Juhl]

On Mon, 14 Nov 2011, Ryan Mallon wrote:

> On 14/11/11 08:55, Jesper Juhl wrote:
> 
> > We test for 'tx_ring' being != zero and BUG() if that's the case. So after
> > that check there is no way that 'tx_ring' could be anything _but_ zero, so
> > testing it again is just dead code. Once that dead code is removed, the
> > 'pkc' local variable becomes entirely redundant, so remove that as well.
> 
> 
> What if CONFIG_BUG=n?
> 

Arrgh, I didn't consider that (should have, but didn't).. In that case 
we'll have 
#define BUG() do {} while(0)
which is not going to work all that peachy with my change...

David: You may want to pass on this one. I obviously didn't think it 
through properly - sorry :-(

-- 
Jesper Juhl <jj@xxxxxxxxxxxxx>       http://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/