Re: [PATCH 3/4] mmc: Logging neatening

[Joe Perches]

On Wed, 2011-11-16 at 10:55 +0900, NamJae Jeon wrote:
> 2011/11/16 Joe Perches <joe@xxxxxxxxxxx>:
> > On Wed, 2011-11-16 at 10:48 +0900, NamJae Jeon wrote:
> >
> > [123K of untrimmed reply]
> >
> > If you wrote something, I didn't find it.
> >
> 
> > -       dev_info(&pdev->dev, "DW MMC controller at irq %d, "
> > -                "%d bit host data width, "
> > -                "%u deep fifo\n",
> > +       dev_info(&pdev->dev,
> > +       "DW MMC controller at irq %d, %d bit host data width, %u deep fifo\n",
> >                 irq, width, fifo_size);
> 
> I think that tab is needed this "DW MMC controller at irq ...." ?

Argument alignment isn't always the right thing.

Very long formats should not necessarily be aligned
at the open parenthesis.  It helps to determine
when the format string or the dmesg output line length
is too long.





--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/