Re: [PATCH RESEND] Fix reboot regression on Acer Aspire One AOA110

[Vasily]

2011/11/3 Peter Chubb <peter.chubb@xxxxxxxxxxxx>:
>>>>>> "Vasily" == Vasily Khoruzhick <anarsoul@xxxxxxxxx> writes:
>
> Vasily> From: UroÅ Vampl <mobile.leecher@xxxxxxxxx> Starting with
> Vasily> kernel 3.0, my Acer Aspire One AOA110 hangs on reboot. Doing
> Vasily> an internet search, I found that in git commit
> Vasily> b49c78d4827be8d7e67e5b94adac6b30a4a9ad14 the machine was made
> Vasily> to reboot with the bios method, but it does not work on most
> Vasily> (all?) AOA110s.
>
> That change was made in July to fix the broken ACPI reboot method. ÂIt
> certainly works on my AOA110. ÂWhat BIOS do you have installed?
> (although looking at what's been published, I can't see any booting
> problems mentioned in the BIOS changelogs).
>
> Vasily> This patch introduces new quirks section for machines that
> Vasily> only reboot with the kbd method and put the Aspire One into
> Vasily> it.
>
> You don't need yet another table, just change the callback.
>
>
> Try this:

Any chance to get this patch merged? Would be nice to see it in stable aswell.

Regards
Vasily

> Index: linux-2.6/arch/x86/kernel/reboot.c
> ===================================================================
> --- linux-2.6.orig/arch/x86/kernel/reboot.c   2011-10-31 14:35:50.105623537 +1100
> +++ linux-2.6/arch/x86/kernel/reboot.c Â2011-11-03 11:54:12.487901547 +1100
> @@ -124,7 +124,7 @@
> Â*/
>
> Â/*
> - * Some machines require the "reboot=b" Âcommandline option,
> + * Some machines require the "reboot=b" or "reboot=k" Âcommandline options,
> Â* this quirk makes that automatic.
> Â*/
> Âstatic int __init set_bios_reboot(const struct dmi_system_id *d)
> @@ -136,6 +136,15 @@
> Â Â Â Âreturn 0;
> Â}
>
> +static int __init set_kbd_reboot(const struct dmi_system_id *d)
> +{
> + Â Â Â if (reboot_type != BOOT_KBD) {
> + Â Â Â Â Â Â Â reboot_type = BOOT_KBD;
> + Â Â Â Â Â Â Â printk(KERN_INFO "%s series board detected. Selecting KBD-method for reboots.\n", d->ident);
> + Â Â Â }
> + Â Â Â return 0;
> +}
> +
> Âstatic struct dmi_system_id __initdata reboot_dmi_table[] = {
> Â Â Â Â{ Â Â Â /* Handle problems with rebooting on Dell E520's */
> Â Â Â Â Â Â Â Â.callback = set_bios_reboot,
> @@ -295,7 +304,7 @@
> Â Â Â Â Â Â Â Â},
> Â Â Â Â},
> Â Â Â Â{ /* Handle reboot issue on Acer Aspire one */
> - Â Â Â Â Â Â Â .callback = set_bios_reboot,
> + Â Â Â Â Â Â Â .callback = set_kbd_reboot,
> Â Â Â Â Â Â Â Â.ident = "Acer Aspire One A110",
> Â Â Â Â Â Â Â Â.matches = {
> Â Â Â Â Â Â Â Â Â Â Â ÂDMI_MATCH(DMI_SYS_VENDOR, "Acer"),
> --
> Dr Peter Chubb                 Âpeter DOT chubb AT nicta.com.au
> http://www.ertos.nicta.com.au        ERTOS within National ICT Australia
> All things shall perish from under the sky/Music alone shall live, never to die
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/