Re: [PATCH 5/8] serial: 8250: reject delaying RTS with RS485

[Wolfram Sang]

> The delay must not necessarily be done by hardware. The drivers/tty/serial/crisv10.c 
> driver, for example, delays through a msleep.
> 
> I don't know if having a software delay in this driver can make sense in some particular 
> circumstance.

Uuuh, I would be against software delays for the same reason why we
don't accept software based direction switching: No guarantees. msleep()
might easily delay longer than what was requested. Or are delay_rts
values to be interpreted as "delay at least"?

Regards,

   Wolfram

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

Attachment: signature.asc
Description: Digital signature