Re: [PATCH] drm/i915: Fix invalid backpanel values for GEN3 or older chips

From: Keith Packard
Date: Thu Nov 17 2011 - 10:17:46 EST


On Wed, 16 Nov 2011 18:14:55 +0100, Takashi Iwai <tiwai@xxxxxxx> wrote:

> While refactoring of backlight control code in commit [a95735569:
> drm/i915: Refactor panel backlight controls], the handling of the bit
> 0 of duty-cycle was gone except for pineview. This resulted in invalid
> register values for old chips like 915GM. When the bit 0 is set, the
> backlight is turned off suddenly.

I'm looking at the mentioned patch and I don't see how that managed to
correctly handle bit 0; is this the patch that managed to break this?

--
keith.packard@xxxxxxxxx

Attachment: pgp00000.pgp
Description: PGP signature